Implement CurvePrimitive.closestPointXY #8844
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeeedtorabi
commented
Dec 16, 2025
| /** | ||
| * Return true if this ClipShape has a local to world transform | ||
| * @deprecated Use duplicate property [[transformValid]] or type guard [[hasTransformFromClip]] instead. | ||
| * @deprecated in 5.0 - will not be removed until after 2026-06-13. Use duplicate property [[transformValid]] or |
Contributor
Author
There was a problem hiding this comment.
@dassaf4 I got a lint error for this. Not sure if what I added is accurate. Please confirm.
saeeedtorabi
commented
Dec 16, 2025
| * @returns arc in the plane defined by the normal at the intermediate point. If calculation fails, return an | ||
| * arc with zero matrix. | ||
| * @deprecated Prefer [[sectionArcInPlaneOfInterpolatedNormal]], which has expanded return type. | ||
| * @deprecated in 5.0 - will not be removed until after 2026-06-13. Prefer [[sectionArcInPlaneOfInterpolatedNormal]], |
Contributor
Author
There was a problem hiding this comment.
@dassaf4 I got a lint error for this. Not sure if what I added is accurate. Please confirm.
saeeedtorabi
commented
Dec 16, 2025
Comment on lines
-789
to
-791
| detailA = child.closestPoint( | ||
| spacePoint, sortedFragment === fragment0 ? extend0 : sortedFragment === fragment1 ? extend1 : false, detailA, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
@dassaf4 I realized it had a bug. Fragments are not curve childs. For example my test curve had 3 child but 15 fragments. Because of that extend was not working fine so had to compare make below change to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.