Conversation
There was a problem hiding this comment.
Tree-Widget benchmark
| Benchmark suite | Current: e2e670b | Previous: 5b928bf | Deviation | Status |
|---|---|---|---|---|
categories tree creates initial filtered view for 50k items |
1609.04 ms |
1838.23 ms |
-12.47% |
✅ |
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) |
459 ms |
454 ms |
1.10% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k subCategories |
8141.56 ms |
6926.63 ms |
17.54% |
🚨 |
categories tree changing definition container visibility changes visibility for 50k subCategories (P95 of main thread blocks) |
68 ms |
64 ms |
6.25% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k categories |
122674.37 ms |
11718.19 ms |
946.87% |
🚨 |
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) |
1976 ms |
139 ms |
1321.58% |
🚨 |
models tree creates initial filtered view for 50k target items |
906.06 ms |
1099.84 ms |
-17.62% |
✅ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
138 ms |
121 ms |
14.05% |
〰️ |
models tree validates categories visibility for imodel with 50k categories |
8366.84 ms |
11753.46 ms |
-28.81% |
✅ |
models tree validates categories visibility for imodel with 50k categories (P95 of main thread blocks) |
89 ms |
82 ms |
8.54% |
〰️ |
models tree changing model visibility changes visibility for 50k elements |
2596.28 ms |
4108.49 ms |
-36.81% |
✅ |
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
133 ms |
-100% |
✅ |
models tree changing category visibility changes visibility for 50k elements |
2812.9 ms |
4276.17 ms |
-34.22% |
✅ |
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
102 ms |
-100% |
✅ |
models tree changing per-model-category override changes visibility for 50k elements |
2697.99 ms |
3997.4 ms |
-32.51% |
✅ |
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
69 ms |
-100% |
✅ |
models tree changing element visibility changes only parent nodes visibility with 50k elements |
4764.14 ms |
7601.06 ms |
-37.32% |
✅ |
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) |
84 ms |
127 ms |
-33.86% |
〰️ |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Pull request overview
This PR updates dependencies across multiple packages and applications in the repository, primarily focusing on bumping versions of iTwin libraries, ESLint tooling, and various development dependencies.
Changes:
- Updated iTwin core libraries and tools to version 5.5.2 across test-viewer, learning-snippets, performance-tests, and test-utilities
- Upgraded ESLint and related plugins to newer versions
- Updated jsdom API calls to use the new
forwardTomethod withjsdomErrors: "none"option - Reformatted interface declarations to improve readability
Reviewed changes
Copilot reviewed 14 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/itwin/tree-widget/src/tree-widget-react/components/trees/models-tree/ModelsTreeComponent.tsx | Reformatted interface declaration for better readability |
| packages/itwin/tree-widget/src/tree-widget-react/components/trees/imodel-content-tree/IModelContentTreeComponent.tsx | Reformatted interface declaration for better readability |
| packages/itwin/tree-widget/src/tree-widget-react/components/trees/external-sources-tree/ExternalSourcesTreeComponent.tsx | Reformatted interface declaration for better readability |
| packages/itwin/tree-widget/src/tree-widget-react/components/trees/categories-tree/CategoriesTreeComponent.tsx | Reformatted interface declaration for better readability |
| packages/itwin/test-utilities/package.json | Updated development dependencies to newer versions |
| packages/itwin/property-grid/src/property-grid-react/components/PropertyGridContent.tsx | Reformatted interface declaration for better readability |
| package.json | Updated root package manager and development dependencies |
| apps/test-viewer/vite.config.mts | Updated SCSS deprecation silencing configuration |
| apps/test-viewer/src/components/App.tsx | Improved error handling to support non-Error objects |
| apps/test-viewer/package.json | Updated dependencies to newer versions |
| apps/performance-tests/src/setup.ts | Updated jsdom VirtualConsole API call |
| apps/performance-tests/package.json | Updated development dependencies and reorganized package order |
| apps/learning-snippets/src/setup.ts | Updated chai import and jsdom VirtualConsole API call |
| apps/learning-snippets/package.json | Updated dependencies to newer versions and reorganized package order |
Files not reviewed (2)
- packages/itwin/test-utilities/pnpm-lock.yaml: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
apps/performance-tests/package.json:1
- TypeScript version ~5.9.3 does not exist. TypeScript's latest stable version as of my knowledge cutoff (January 2025) is 5.8.x. Please verify this version exists or use a valid version such as ~5.8.0.
{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Looks like performance test slowdowns in categories tree coming from |
Bumped dependencies in test-viewer, learning-snippets, performance-tests and test-utilities.
Updated property-grid and tree-widget screenshots due to
itwinui-reactversion bump changed expander icon size.