fix(locale): remove unnecessary RLM characters from Arabic locale format L#2986
Open
DanielDerefaka wants to merge 1 commit intoiamkun:devfrom
Open
fix(locale): remove unnecessary RLM characters from Arabic locale format L#2986DanielDerefaka wants to merge 1 commit intoiamkun:devfrom
DanielDerefaka wants to merge 1 commit intoiamkun:devfrom
Conversation
…mat L The Arabic locale format L contained Right-to-Left Mark (U+200F) characters that caused incorrect date rendering in HTML contexts. These RLM characters are unnecessary for correct Arabic formatting since numbers and dates are written left-to-right in Arabic typography. Fixes iamkun#2977 Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=101010297
Author
|
@cj would you review this PR? |
Ayo1984
reviewed
Jan 13, 2026
| LT: 'HH:mm', | ||
| LTS: 'HH:mm:ss', | ||
| L: 'D/M/YYYY', | ||
| L: 'D/M/YYYY', |
Contributor
There was a problem hiding this comment.
Could you add a unit test or update if there's one already?
Author
There was a problem hiding this comment.
I will do that right away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unnecessary Right-to-Left Mark (U+200F) characters from the Arabic locale
Ldate format.Problem
The Arabic locale format
Lcontained RLM characters (D/M/YYYY) that caused:Solution
Removed the RLM characters from the format:
D/M/YYYYThis is the correct approach because numbers and dates are written left-to-right in Arabic typography and should not have their direction altered by RLM characters.
Test plan
Fixes #2977
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=101010297