chore: support new architecture#84
Draft
MounirDhahri wants to merge 3 commits intoiamolegga:masterfrom
Draft
Conversation
10 tasks
MounirDhahri
force-pushed
the
chore/migrate-to-new-architecture
branch
2 times, most recently
from
1823c6f to
f028d1b
Compare
chore: follow-up fixes chore: upgrade packages and fix typings
MounirDhahri
force-pushed
the
chore/migrate-to-new-architecture
branch
from
e0c1a1e to
2058fd7
Compare
|
Can we release this?.. |
MounirDhahri
force-pushed
the
chore/migrate-to-new-architecture
branch
from
626cab8 to
4235bb3
Compare
MounirDhahri
force-pushed
the
chore/migrate-to-new-architecture
branch
from
4235bb3 to
b5fb3dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new architecture on iOS.
Android seems to be compiling fine - I still didn't test if it also works fine🤞🏽
This PR makes changes to the package code that might break the example app. I tried upgrading the latter and it took longer than I wanted it to be. My suggestion would be to migrate it to use expo with prebuild to avoid maintaining it and make future upgrades easier