Closed
Conversation
ezrobot
requested review from
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
Steveb-p
reviewed
Oct 22, 2025
|
|
||
| $tableName = $metadata->getTableName(); | ||
| if (isset($this->tableToMetadata[$tableName])) { | ||
| if (isset($this->tableToMetadata[$tableName]) && $this->tableToMetadata[$tableName] != $metadata) { |
Contributor
There was a problem hiding this comment.
To put it simply, if two metadata services exist for the same table (even if they have the exact same properties), that is an error and shall not be ignored :)
The error should be found and removed, not silently ignored.
Author
There was a problem hiding this comment.
@Steveb-p so we need to fix it in https://github.com/ibexa/product-catalog/ somehow ? Should i close this PR ?
Author
|
closed - as issue likely need to be fixed in https://github.com/ibexa/product-catalog/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"By design" we allow multiple attributes/gateways per table for custom product attributes (see https://doc.ibexa.co/en/4.6/pim/create_custom_attribute_type/ where
Attribute\Float\StorageSchemais used for a custom attribute).