fix: cancel previous entry if we are previewing different entry#2551
Merged
ibhagwan merged 2 commits intoibhagwan:mainfrom Feb 5, 2026
Merged
fix: cancel previous entry if we are previewing different entry#2551ibhagwan merged 2 commits intoibhagwan:mainfrom
ibhagwan merged 2 commits intoibhagwan:mainfrom
Conversation
Contributor
Author
|
Not sure if we have a way to cancel a coroutine. Maybe not possible in lua 5.1. |
phanen
force-pushed
the
async-cancellation
branch
from
a5c4158 to
bde9241
Compare
The root cause is query isn't copied to opts.__alt_opts
The execute order of parse_entry callback can be random when it's slow (e.g. callback in network request) self:debounce don't work here, because we run a async parse_entry callback again in the debounce timer callback
phanen
force-pushed
the
async-cancellation
branch
3 times, most recently
from
bde9241 to
614d8ae
Compare
Owner
|
Ty @phanen ” |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execute order of parse_entry callback can be random when it's slow
(e.g. callback in network request)
self:debounce don't work here, because we run a async parse_entry
callback again in the debounce timer callback