This repository was archived by the owner on Sep 23, 2025. It is now read-only.
Added support for Width & Height scale to the pictures#4
Open
moattarwork wants to merge 1 commit intomasterfrom
Open
Added support for Width & Height scale to the pictures#4moattarwork wants to merge 1 commit intomasterfrom
moattarwork wants to merge 1 commit intomasterfrom
Conversation
french-justin
approved these changes
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The PR includes adding scaling capability to the image by either height or width.
New Features
Closes Add capability to picture to be able to be sized with Width or Height and calculate the other dimension as a ratio to the original one #3
Closes Added support for Width & Height scale to the pictures #4
Type of change
Please delete options that are not relevant.
Dependent Releases
Nothing
Required Configuration on CI/CD platform
Nothing
How Has This Been Tested?
It's been tested through unit testing
Checklist: