[WIP] Alternate approach to async reads in ZipAESStream#624
Draft
Numpsy wants to merge 2 commits intoicsharpcode:masterfrom
Draft
[WIP] Alternate approach to async reads in ZipAESStream#624Numpsy wants to merge 2 commits intoicsharpcode:masterfrom
Numpsy wants to merge 2 commits intoicsharpcode:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 73.82% 73.87% +0.05%
==========================================
Files 69 69
Lines 8291 8311 +20
==========================================
+ Hits 6121 6140 +19
- Misses 2170 2171 +1
Continue to review full report at Codecov.
|
Numpsy
force-pushed
the
rw/async/async_decryption_2
branch
from
063d306 to
f8b19ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate approach to #576 which tries taking the simpler approach of using the 'useAsync' idea that some MS libs use for sharing async/sync versions of a function instead of duplicating all the logic, in order to only have a single version of
ReadAndTransformI certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.