GZipOutputStream is the destination and not the source#741
Open
nickl- wants to merge 1 commit intoicsharpcode:gh-pagesfrom
Open
GZipOutputStream is the destination and not the source#741nickl- wants to merge 1 commit intoicsharpcode:gh-pagesfrom
nickl- wants to merge 1 commit intoicsharpcode:gh-pagesfrom
Conversation
Changed the variable names to make it clear and assign the correct stream order to the `Copy` function. Fixed typo in `StreamUtils` class name
piksel
requested changes
Apr 6, 2022
Member
piksel
left a comment
There was a problem hiding this comment.
The documentation is generated from the comments and will be overwritten next time they are generated. The change should go here:
SharpZipLib/src/ICSharpCode.SharpZipLib/GZip/GzipOutputStream.cs
Lines 26 to 33 in cc8dd78
I personally think the in and out is less helpful than fs and gzos, as long as the order is correct (which it obviously wasn't in this case).
Member
It's because ICSharpCode is a (non-profit) organization that may need to actually deal with legal stuff :( |
Member
|
History - see issue #103 (plus my comment here #101 (comment)). That little snippet ensures that the entire code base is properly MIT-licensed for everyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the variable names to make it clear and assign the correct stream order to the
Copyfunction.Fixed typo in
StreamUtilsclass nameI certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.
Wow!! what's with all the legalese =(