Add support for DEFLATE64 algorithm when extracting from zip archive#818
Open
elitzamarinova wants to merge 1 commit intoicsharpcode:masterfrom
Open
Add support for DEFLATE64 algorithm when extracting from zip archive#818elitzamarinova wants to merge 1 commit intoicsharpcode:masterfrom
elitzamarinova wants to merge 1 commit intoicsharpcode:masterfrom
Conversation
| { | ||
| int oldSize = rawData.Length; | ||
| byte[] resized = rawData; | ||
| Array.Resize(ref resized, bufferSize); |
Member
There was a problem hiding this comment.
You are aware that is a costly copy operation?
Author
There was a problem hiding this comment.
Yes, I am. But in this particular case I don't think that it is significant.
Member
|
This currently fails 4 tests, and I am not too eager in taking in a whole new Deflate implementation (1800 LoC 😓). I did some PoC testing in c9589cf to see if it could be implemented by allowing the window and max distance to be customized in the existing Deflater. |
Author
|
Yes, looks promising. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for DEFLATE64 algorithm when extracting from zip archive:
The content of the new classes is borrowed from DEFLATE64 support implementation for DotNetZip which on its part contains modified code from the .NET Core Libraries (CoreFX and System.IO.Compression/DeflateManaged) where deflate64 decompression is implemented.
Other changes are implemented in order to support forward-only stream.