Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of the PR:
we want to avoid generating fields that are deprecated on the SDK data model. However this will not work as we use strict deserialization in the SDK, and the current serialization method still puts empty collections because of
JsonInclude.Include.NON_NULL.The proposed solution is:
Extend the functionality of the existing custom Spring encoder to accept 2 mappers: one with
setSerializationInclusion(JsonInclude.Include.NON_NULL)and the other withsetSerializationInclusion(JsonInclude.Include.NON_EMPTY). The latter wil be used only if the headerCardinal-Json-Modewith valueNOT_EMPTYis present in the request. This way, we can leverage the non empty serializaztion strategy for the SDK but still allow the previous behavior for the old typescript SDK.Remove the
@JsonInclude(JsonInclude.Include.NON_NULL)annotation in DTO classes that have deprecated fields. This has no impact as the current mapper already has theJsonInclude.Include.NON_NULLdefault behaviour.Add the
@param:JsonInclude(JsonInclude.Include.NON_NULL)annotation to fields with nullable collection types.