Conversation
sgaist
force-pushed
the
refactor/self-contained
branch
from
90ec896 to
914c262
Compare
This will allow to remove duplicates declarations which also means that each sub package has its own variant but they are mostly the same.
This will allow other packages requiring pip to use the same code to get the requirements.
This refactor allows to make the pipenv installation "self contained" as it will also make use of this buildpack to provide pip.
This refactor allows to make the poetry installation "self contained" as it will also make use of this buildpack to provide pip.
This is required to allow for the buildpack to be self-serving. Self-serving means that pipenv and poetry requiring pip will get it from this very buildpack.
sgaist
force-pushed
the
refactor/self-contained
branch
from
914c262 to
a559ef0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR makes this buildpack fully self-contained.
Up until now, it still relied on the pip buildpack for pipenv and poetry.
This is not longer the case as pip is "self-provided" for these two package managers.
As drive by improvements: