add support for root-node #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases I can get json with multiple schemas for example REST definition GET/POST/DELETE etc. This change will try to find node in json and use it as schema.
idubinskiy
requested changes
Mar 30, 2017
Owner
idubinskiy
left a comment
idubinskiy
left a comment
There was a problem hiding this comment.
Thanks for the PR!
This will only look at top-level nodes, so that should probably be clarified somewhere. Probably the command line flag description or README. Or both. Either way, please update the README.
| log.Fatalln("Error parsing JSON:", err) | ||
| } | ||
| node, ok := sub[*rootNodeName] | ||
| if ok == false { |
| if err = json.Unmarshal(file, &s); err != nil { | ||
| log.Fatalln("Error parsing JSON:", err) | ||
| if *rootNodeName != "" { | ||
|
|
Owner
There was a problem hiding this comment.
Please remove this empty line.
| } | ||
| node, ok := sub[*rootNodeName] | ||
| if ok == false { | ||
| log.Fatalln(fmt.Sprintf("Error JSON node '%s' does not exists:", *rootNodeName), err) |
Owner
There was a problem hiding this comment.
Instead of combining log.Fatalln and fmt.Sprintf, use log.Fatalf. Don't forget to add \n at the end of the format string.
| if ok == false { | ||
| log.Fatalln(fmt.Sprintf("Error JSON node '%s' does not exists:", *rootNodeName), err) | ||
| } | ||
| //log.Panicf("Error reading file %v:", node) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases I can get json with multiple schemas for example REST definition GET/POST/DELETE etc.
This change will try to find node in json and use it as schema.