Skip to content

[bugfix] Issue 665 Fixed resource leak related to sshClient #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dk2k wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[bugfix] Issue 665 Fixed resource leak related to sshClient #666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions datasophon-service/src/main/java/com/datasophon/api/utils/MinaUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,19 @@ public class MinaUtils {

/** 打开远程会话 */
public static ClientSession openConnection(String sshHost, Integer sshPort, String sshUser) {
SshClient sshClient = SshClient.setUpDefaultClient();
sshClient.start();
ClientSession session = null;
String privateKeyPath = System.getProperty("user.home") + Constants.ID_RSA;
try {
try (SshClient sshClient = SshClient.setUpDefaultClient()) {
sshClient.start();
String privateKeyPath = System.getProperty("user.home") + Constants.ID_RSA;

String privateKeyContent = new String(Files.readAllBytes(Paths.get(privateKeyPath)));
session = sshClient.connect(sshUser, sshHost, sshPort).verify().getClientSession();
session.addPublicKeyIdentity(getKeyPairFromString(privateKeyContent));
if (session.auth().verify().isFailure()) {
LOG.info("验证失败");
return null;
}

} catch (IOException e) {
throw new RuntimeException(e);
}
Expand Down