Allow to use user group with roles on create/update chat room.#41
Open
rburakov wants to merge 1 commit intoigniterealtime:mainfrom
Open
Allow to use user group with roles on create/update chat room.#41rburakov wants to merge 1 commit intoigniterealtime:mainfrom
rburakov wants to merge 1 commit intoigniterealtime:mainfrom
Conversation
… room create/update endpoint.
Contributor
|
How would you differentiate between a member and a group? E.g. |
Author
|
Hi Roman, Using user bare JID for user member together with a group name for group member will fix the issue: In case when a username (not a bare JID) is specified and it equals to a group name, group wins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
We can use Add group with role to chat room endpoint to add a new group with role to a room. Suppose, it should be also possible to do when creating / updating a chat room.
E.g.:
Please review and let me know what do you think.