Fix onChange not firing when typing previous value#656
Open
thiagorb wants to merge 1 commit intoigorescobar:masterfrom
Open
Fix onChange not firing when typing previous value#656thiagorb wants to merge 1 commit intoigorescobar:masterfrom
thiagorb wants to merge 1 commit intoigorescobar:masterfrom
Conversation
The current implementation is not firing the onChange callback passed in the options. This happens because the oldValue variable is updated only on blur. With this changes, two variables are used. One controls the value that the element had when it got focus, and the other one is changed immediately after every change.
Owner
|
Thanks for this @thiagorb I will give it a shot ASAP. |
Contributor
This was referenced Aug 6, 2018
Closed
Owner
|
@ankurk91 have you tested this PR? |
Contributor
|
@igorescobar |
mmartinsoliv
approved these changes
Jun 17, 2021
mmartinsoliv
approved these changes
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation is not firing the onChange callback passed in
the options.
This happens because the oldValue variable is updated only on blur. With
this changes, two variables are used. One controls the value that the
element had when it got focus, and the other one is changed immediately
after every change.
Fiddle that reproduces the problem: https://jsfiddle.net/kp5hq1e8/7/
Steps to reproduce:
It was expected that the onChange callback would be fired every time, but when entering the value that the input had when it lost focus nothing happens.
Output of the fiddle with the steps above:
Expected output: