feat: Add extraLinesData support to CandlestickChart#2016
Open
owenmoon1 wants to merge 1 commit intoimaNNeo:mainfrom
Open
feat: Add extraLinesData support to CandlestickChart#2016owenmoon1 wants to merge 1 commit intoimaNNeo:mainfrom
owenmoon1 wants to merge 1 commit intoimaNNeo:mainfrom
Conversation
Owner
|
Thanks, Owen, it already looks good to me. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2016 +/- ##
==========================================
- Coverage 92.49% 92.47% -0.02%
==========================================
Files 50 50
Lines 3731 3735 +4
==========================================
+ Hits 3451 3454 +3
- Misses 280 281 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Can you please add the unit tests for the new changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Add extraLinesData support to CandlestickChart
Adds
extraLinesDatasupport to the CandlestickChart, implementing the same functionality available in LineChart.Changes:
extraLinesDataparameter toCandlestickChartDataUse Case:
This feature enables traders and developers to draw reference lines on candlestick charts, such as:
Example:
See the updated
candlestick_chart_sample1.dartfor a working example showing a yellow median price line across Bitcoin prices.Testing: