Conversation
The refactoring of the insert commands means that the logic is now way simpler, as our document assumptions have been simplified. There was also a bug that we inserted 3 code blocks at a time (I think because we were inserting on the edge of a node??), there is a TODO there since I don't fully understand the cause of that bug yet.
…nction in mathinline.test.ts
|
Use the mapping to store the linenumbers
…hlight-verbose Add Verbose syntax highlighting support
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Roadmap:
a. Inserting above fails to insert the proper newline after the inserted node?
b. Inserting below also does not always insert the proper newline after the inserted node.
innerRangetocontentRange? Also renamedrangetotagRangeas per suggestion by @XyntaxCS. (@DikieDick)a. It does work when the node selection is a markdown cell.
findNodeByProsePosuses binary search already.wpWrapInandwpLiftpmRangeandprosemirrorStart/prosemirrorEnd?Resolves #33 and #28