Skip to content

Update for Improv 2.4 commands/capabilities #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yinzara wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update for Improv 2.4 commands/capabilities #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e26c0c
Update for Improv 2.4 commands/capabilities
yinzara Dec 19, 2025
94324ed
Fixing capability bitmasks
yinzara Dec 27, 2025
c980be6
Adding parsing of hostname/device name
yinzara Dec 27, 2025
6e8764c
Reverting improv serial version to 1
yinzara Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/improv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,17 @@ ImprovCommand parse_improv_data(const uint8_t *data, size_t length, bool check_c
std::string ssid(data + ssid_start, data + ssid_end);
std::string password(data + pass_start, data + pass_end);
return {.command = command, .ssid = ssid, .password = password};
} else if ((command == HOSTNAME || command == DEVICE_NAME) && data[2] > 0) {
uint8_t name_length = data[2];
uint8_t name_start = 3;
size_t name_end = name_start + name_length;
if (name_end > length) {
improv_command.command = UNKNOWN;
return improv_command;
}

std::string name(data + name_start, data + name_end);
return {.command = command, .name = name};
}

improv_command.command = command;
Expand Down
10 changes: 9 additions & 1 deletion src/improv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ enum Error : uint8_t {
ERROR_UNKNOWN_RPC = 0x02,
ERROR_UNABLE_TO_CONNECT = 0x03,
ERROR_NOT_AUTHORIZED = 0x04,
ERROR_BAD_HOSTNAME = 0x05,
ERROR_UNKNOWN = 0xFF,
};

Expand All @@ -42,10 +43,16 @@ enum Command : uint8_t {
GET_CURRENT_STATE = 0x02,
GET_DEVICE_INFO = 0x03,
GET_WIFI_NETWORKS = 0x04,
HOSTNAME = 0x05,
DEVICE_NAME = 0x06,
BAD_CHECKSUM = 0xFF,
};

static const uint8_t CAPABILITY_IDENTIFY = 0x01;
static const uint8_t CAPABILITY_IDENTIFY = 1 << 0;
static const uint8_t CAPABILITY_GET_DEVICE_INFO = 1 << 1;
static const uint8_t CAPABILITY_GET_WIFI_NETWORKS = 1 << 2;
static const uint8_t CAPABILITY_HOSTNAME = 1 << 3;
static const uint8_t CAPABILITY_DEVICE_NAME = 1 << 4;
static const uint8_t IMPROV_SERIAL_VERSION = 1;
Copy link
Author

@yinzara yinzara Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the serial version unchanged for now but this may change in the future.


enum ImprovSerialType : uint8_t {
Expand All @@ -59,6 +66,7 @@ struct ImprovCommand {
Command command;
std::string ssid;
std::string password;
std::string name; // hostname or device_name
};

ImprovCommand parse_improv_data(const std::vector<uint8_t> &data, bool check_checksum = true);
Expand Down