IWF-1153: checking all S3 objects aginst Temporal#598
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (73.68%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
==========================================
+ Coverage 65.65% 65.70% +0.04%
==========================================
Files 64 64
Lines 6464 6461 -3
==========================================
+ Hits 4244 4245 +1
+ Misses 1895 1893 -2
+ Partials 325 323 -2
🚀 New features to boost your workflow:
|
| totalDeleted++ | ||
| logger.Info("CleanupBlobStore deleted workflow objects", "workflowPath", workflowPath) | ||
| } else if err != nil { | ||
| logger.Error("CleanupBlobStore failed to describe workflow", "workflowPath", workflowPath, "error", err) |
There was a problem hiding this comment.
we're returning and throwing an error here if describe workflow fails because that means the workflow is likely no longer running?
There was a problem hiding this comment.
The other errors describe workflow can return besides NotFound error are:
// - serviceerror.InvalidArgument
// - serviceerror.Internal
// - serviceerror.Unavailable
Describe workflow is an expensive call and can take up lots of resources. So if we get any of the above errors, I think we'd want to fix the issue or wait before running it again.
|
overall looks good to me! I would approve this if I could! |
Description
Checklist
Related Issue
Closes #issue_number