Skip to content

IWF-1153: checking all S3 objects aginst Temporal#598

Merged
ktrops merged 1 commit intomainfrom
jira/katiea/IWF-1153
Jan 9, 2026
Merged

IWF-1153: checking all S3 objects aginst Temporal#598
ktrops merged 1 commit intomainfrom
jira/katiea/IWF-1153

Conversation

@ktrops
Copy link
Contributor

@ktrops ktrops commented Jan 8, 2026

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #issue_number

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.70%. Comparing base (b357107) to head (6de36d0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
service/interpreter/activityImpl.go 61.53% 4 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (73.68%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
+ Coverage   65.65%   65.70%   +0.04%     
==========================================
  Files          64       64              
  Lines        6464     6461       -3     
==========================================
+ Hits         4244     4245       +1     
+ Misses       1895     1893       -2     
+ Partials      325      323       -2     
Files with missing lines Coverage Δ
service/interpreter/cadence/workflow.go 100.00% <100.00%> (ø)
service/interpreter/temporal/workflow.go 100.00% <100.00%> (ø)
service/interpreter/workflowImpl.go 86.81% <100.00%> (+0.03%) ⬆️
service/interpreter/activityImpl.go 78.20% <61.53%> (+0.73%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

totalDeleted++
logger.Info("CleanupBlobStore deleted workflow objects", "workflowPath", workflowPath)
} else if err != nil {
logger.Error("CleanupBlobStore failed to describe workflow", "workflowPath", workflowPath, "error", err)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're returning and throwing an error here if describe workflow fails because that means the workflow is likely no longer running?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other errors describe workflow can return besides NotFound error are:
// - serviceerror.InvalidArgument
// - serviceerror.Internal
// - serviceerror.Unavailable

Describe workflow is an expensive call and can take up lots of resources. So if we get any of the above errors, I think we'd want to fix the issue or wait before running it again.

@dillia23
Copy link

dillia23 commented Jan 8, 2026

overall looks good to me! I would approve this if I could!

@ktrops ktrops merged commit ed9f8c2 into main Jan 9, 2026
9 of 10 checks passed
@ktrops ktrops deleted the jira/katiea/IWF-1153 branch January 9, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants