Set TypeReader.symbols_with_unknown_types at init#632
Open
zachjweiner wants to merge 1 commit intoinducer:mainfrom
Open
Set TypeReader.symbols_with_unknown_types at init#632zachjweiner wants to merge 1 commit intoinducer:mainfrom
zachjweiner wants to merge 1 commit intoinducer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a blind fix (for the superficial issue, but might be symptomatic of some other problem) for, e.g., the following kernel:
which throws
AttributeError: 'TypeReader' object has no attribute 'symbols_with_unknown_types'from this line.TypeReaderis simply missing asymbols_with_unknown_typesattribute that its base class has (as well as other attributesTypeInferenceReadersets at__init__, incidentally). (The example is a minimal one derived roughly fromtest_global_parallel_reduction, for context. The resulting kernel looks fine after this fix.)