Open
Conversation
Owner
|
Thanks! Could you look at the test failures? The typo and the type errors will get addressed via #937 before this lands, so feel free to ignore those for now, unless they seem related to your code. Edit: you can also ignore the doctest mismatches (in |
Owner
|
#937 has landed, and CI on the main branch now passes cleanly. It might be worth updating this to see how things go. |
inducer
reviewed
Jun 14, 2025
inducer
reviewed
Jul 10, 2025
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! Here's some feedback from a first look.
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
inducer
force-pushed
the
opencl_allocation
branch
from
3a86afd to
b24fe99
Compare
inducer
reviewed
Oct 31, 2025
| return frozenset(result) | ||
|
|
||
|
|
||
| def _get_temporaries_accessed_in_schedule( |
Owner
There was a problem hiding this comment.
Can this handle RunInstruction outermost?
|
|
||
|
|
||
| @memoize_on_first_arg | ||
| def get_sched_index_to_first_and_last_used( |
Owner
There was a problem hiding this comment.
Rather than "implicitly" attaching allocations to schedule items, maybe realize them explicitly as a new kind of schedule item?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.