ElementwiseKernel: add get_global and fix bug in get_texref#173
Open
bailsman wants to merge 1 commit intoinducer:mainfrom
Open
ElementwiseKernel: add get_global and fix bug in get_texref#173bailsman wants to merge 1 commit intoinducer:mainfrom
bailsman wants to merge 1 commit intoinducer:mainfrom
Conversation
Owner
|
Could you add/update the docs? |
Contributor
Author
|
Hmm. What's a good place to document this? ElementwiseKernel is only mentioned briefly in doc/source/array.rst. I suppose I could add a sentence there that .get_global() works on ElementwiseKernel. There's also the detail that to use an old style texref, you have to bind it to the module, and we don't provide an easy interface to do that yet. If we want to document and make get_texref() easy to actually use, maybe we should have get_texref() automatically add the texref to module.texrefs so that they get bound whenever you call the module. Or we could encourage people to use texture objects instead ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds get_global to ElementwiseKernel so you can use constant memory in one.
get_texref was also broken: the use_range parameter was a kwarg instead of normal arg, causing the memoizer to see it as a different call. So you'd get a texref to a different module.