Open
Conversation
inducer
reviewed
Dec 14, 2020
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks for your contribution. A few comments below.
| @@ -533,10 +533,10 @@ class BoostLibraries(Libraries): | |||
| def __init__(self, lib_base_name, default_lib_name=None): | |||
Owner
There was a problem hiding this comment.
Please keep this PR to a single topic (and file a separate PR for installation-related changes, if desired).
src/cpp/cuda.hpp
Outdated
| virtual void detach_internal() | ||
| { | ||
| // Primary context comes from retainPrimaryContext. | ||
| // Leo: commenting out |
src/cpp/cuda.hpp
Outdated
| { | ||
| // Primary context comes from retainPrimaryContext. | ||
| // Leo: commenting out | ||
| //#if CUDAPP_CUDA_VERSION >= 7000 |
Owner
There was a problem hiding this comment.
Please don't leave commented out code sitting around.
removing comments
going back to master
going back to master
removing comments
ilciavo
commented
Dec 17, 2020
Author
ilciavo
left a comment
ilciavo
left a comment
There was a problem hiding this comment.
Removing changes from installation files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.