Conversation
Currently executing `make all` just fails and does not even execute all the checks either. The current makefile seems to be quite different that the one traditionally used, and I don't really want to spend too much time on it. So I copied the one from PhpSpec, adapted to keep the existing setup (e.g. here we have PHP-CS-Fixer as a PHAR not a dev dep and we do not have Rector). Now `make all` works.
maks-rafalko
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently executing
make alljust fails and does not even execute all the checks either.The current makefile seems to be quite different that the one traditionally used, and I don't really want to spend too much time on it. So I copied the one from PhpSpec, adapted to keep the existing setup (e.g. here we have PHP-CS-Fixer as a PHAR not a dev dep and we do not have Rector).