fix(inputs.prometheus): cleanup shared informers on stop.#18304
Open
redbaron wants to merge 1 commit intoinfluxdata:masterfrom
Open
fix(inputs.prometheus): cleanup shared informers on stop.#18304redbaron wants to merge 1 commit intoinfluxdata:masterfrom
redbaron wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
When telegraf configuration is reloaded, Stop() for every plugin is called followed by Start() for all plugins. Prometheus plugin's Stop() cancels context used to initialize shared informer in the `watchPod`, which then cause informer to stop. Stopped informers cannot be restarted, so we need to remove informers from the global map. This will allow subsequent Start() to initialize fresh informer.
telegraf-tiger
bot
added
area/prometheus
fix
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When telegraf configuration is reloaded, Stop() for every plugin is called followed by Start() for all plugins.
Prometheus plugin's Stop() cancels context used to initialize shared informer in the
watchPod, which then causeinformer to stop.
Stopped informers cannot be restarted, so we need to remove informers from the global map. This will allow subsequent Start() to initialize fresh informer.
Checklist
Related issues
resolves #18303