Reduce chunkSize to avoid internal error#176
Open
rodarima wants to merge 1 commit intoinsomniacslk:masterfrom
Open
Reduce chunkSize to avoid internal error#176rodarima wants to merge 1 commit intoinsomniacslk:masterfrom
rodarima wants to merge 1 commit intoinsomniacslk:masterfrom
Conversation
Owner
|
Thanks @rodarima ! The large number for user pagination was done to speed up joining large Slack teams. I suspect that decreasing to 30 will defeat that speed gain, we should verify that. |
Author
|
Thanks @rodarima ! The large number for user pagination was done to
speed up joining large Slack teams. I suspect that decreasing to 30
will defeat that speed gain, we should verify that.
I tested with a `chunkSize` of 40 users and it was already returning the
internal error, so I don't thing there is much room for improvement with
this endpoint. Maybe we could use the `list.users` to fetch all the
users at the beginning and then ensure that the list is kept updated
when joining channels (or when a user id is found to be new) by fetching
only the new users (either one by one or using the legacy method).
Furthermore the Slack API of `users.info` seems to have changed
compared to the slack-go implementation - the latter uses `users` as
parameter, while (now?) the API method expects a singular `user`. I
wonder how does this even work with a different argument
I guess they have changed the API and the documentation, but they have
left the legacy working for some time. It is likely to be broken soon.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #170