Open
Conversation
added 2 commits
August 12, 2019 11:47
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
|
Code Climate has analyzed commit f1611fb and detected 9 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
|
Pushing this to Backlog to look at once we get Cisco resources to use for verification |
Contributor
Author
|
If this helps, I might be able to give you remote access to one. That won't help much for continued verification, though. For that case, it would be better to set up some GNS3- or VIRL-based solution in your infrastructure (which'd be needed for later in-depth Cisco work anyway). |
Contributor
|
@tecracer-theinen Any chance you can rebase this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add detection of Cisco ASA security appliances.
Related Issue
none
Types of changes
Checklist: