CHEF-2414 Deprecate azure connections from train#746
Merged
clintoncwolfe merged 4 commits intomainfrom Oct 18, 2023
Merged
Conversation
4 tasks
Signed-off-by: Sathish <sbabu@progress.com>
ecf1330 to
0f4fa49
Compare
Signed-off-by: Sathish <sbabu@progress.com>
ahasunos
approved these changes
Jun 26, 2023
clintoncwolfe
requested changes
Jun 26, 2023
Contributor
clintoncwolfe
left a comment
There was a problem hiding this comment.
I'm going to ask that we do this without using ActiveSupport. We try to keep it out of train-core (and no, azure transport is not in train-core) but I think the only reason train has an active_support dependency was due to azure. I think active support dependencies need to be well-justified. Here we could get by with a warning.
…-warn-azure-deprecation
Signed-off-by: Sathish <sbabu@progress.com>
clintoncwolfe
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: inspec-azure will continue to work. Using
inspec exec -t azure://will continue to work.Warns the users that long unused Azure connections from train would be deprecated.
Description
As part of removing the long unused Azure SDKs from train, this change is the first part where we let know the users about deprecating this Azure Connection.
While target platform
azuremeaning-t azurewould still continue to work.Things that will be deprecated -
Related Issue
second part: #745
https://chefio.atlassian.net/browse/CHEF-2414
Types of changes
Checklist: