Merged
Conversation
Collaborator
|
@Jawnnypoo i think the spotless checks are failing 😎 . glad that's working. let me push a small commit up and see if i can get this passing again. |
Collaborator
|
This change makes sense to me. it feels fair to push to a newer construct/object when configuring |
kaushikgopal
approved these changes
Mar 29, 2023
Collaborator
kaushikgopal
left a comment
kaushikgopal
left a comment
There was a problem hiding this comment.
waiting for CI to pass, will merge right after 🙏🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin has
Duration, which is nice because you can specify in.milliseconds,.hours, or whatever else you like. So, this would be a nice way of allowing users to not have to convert everything to milliseconds if they wanted to use seconds or minutes.Internally, within Sntp, it will still use milliseconds, since I don't think we want to deal with the interop of using Kotlin duration within Java 😅