Add simple JavaScript bubble sort implementation#2
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
|
|
||
| // Example usage | ||
| if (require.main === module || typeof window === 'undefined') { |
There was a problem hiding this comment.
Bug: Example Usage Block Causes Environment Checks Failures
The example usage block's condition has a couple of issues: it causes a ReferenceError in browser environments by accessing require when undefined, and in Node.js, the typeof window === 'undefined' check makes the condition always true, causing the example code to run every time the module is imported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a simple bubble sort implementation in JavaScript with example usage.
Note
Add bubble sort implementations in JavaScript and Python with example usage and JS module export.
bubble_sort.js):bubbleSort(arr)that returns a sorted copy; includes example CLI usage andmodule.exportsexport.bubble_sort.py):bubble_sort(arr)that returns a sorted copy; includes example CLI usage.Written by Cursor Bugbot for commit 77df777. Configure here.