Skip to content

[MBL-19738][Student] - Offline: Use toast instead of 'No internet connection' dialog while bookmarking Grades #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdeakinstructure merged 1 commit into from
Feb 4, 2026
+2 −2
Merged

[MBL-19738][Student] - Offline: Use toast instead of 'No internet connection' dialog while bookmarking Grades #3500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/student/src/main/java/com/instructure/student/features/grades/GradesFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.widget.Toast
import androidx.compose.runtime.collectAsState
import androidx.compose.runtime.getValue
import androidx.compose.ui.platform.ComposeView
Expand Down Expand Up @@ -50,7 +51,6 @@ import com.instructure.pandautils.utils.collectOneOffEvents
import com.instructure.pandautils.utils.color
import com.instructure.pandautils.utils.makeBundle
import com.instructure.pandautils.utils.orDefault
import com.instructure.pandautils.utils.showNoConnectionDialog
import com.instructure.pandautils.utils.withArgs
import com.instructure.student.R
import com.instructure.student.activity.NavigationActivity
Expand Down Expand Up @@ -95,7 +95,7 @@ class GradesFragment : ParentFragment(), Bookmarkable {
if (APIHelper.hasNetworkConnection()) {
(activity as? NavigationActivity)?.addBookmark()
} else {
showNoConnectionDialog(context)
Toast.makeText(requireContext(), getString(R.string.notAvailableOffline), Toast.LENGTH_SHORT).show()
}
}
),
Expand Down
Loading