[MBL-19738][Student] - Offline: Use toast instead of 'No internet connection' dialog while bookmarking Grades#3500
Merged
kdeakinstructure merged 1 commit intomasterfrom Feb 4, 2026
Conversation
…des page while bookmarking it, to be consistent with other pages. refs: MBL-19738 affects: Student release note: Use toast instead of 'No Internet Connection' while bookmarking Grades in offline mode.
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
🧪 Unit Test Results✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Wed, 04 Feb 2026 10:32:22 GMT |
kristofnemere
approved these changes
Feb 4, 2026
apps/student/src/main/java/com/instructure/student/features/grades/GradesFragment.kt
Show resolved
Hide resolved
|
Student Install Page |
Contributor
|
I think, more pages show Dialog in this case, if we want to change this, it would be better to collect all the places and create a ticket for all, not like one by one. |
kdeakinstructure
deleted the
MBL-19738-offline-grades-toast-instead-no-internet-dialog
branch
Contributor
Author
Yeah, made a ticket, there may be some pages left. It's MBL-19763 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement using toast instead of No Internet Connection dialog on Grades page while bookmarking it, to be consistent with other pages.
refs: MBL-19738
affects: Student
release note: Use toast instead of 'No Internet Connection' while bookmarking Grades in offline mode.