Skip to content

[MBL-19756][Student] Fix NullPointerException when displaying conference recordings with null length #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kristofnemere merged 2 commits into from
Feb 5, 2026
+49 −4
Merged

[MBL-19756][Student] Fix NullPointerException when displaying conference recordings with null length #3503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fce5e2c
[MBL-19756][Student] Fix NullPointerException when displaying confere…
kristofnemere Feb 4, 2026
d438550
Prioritize presentation type playback format over notes
kristofnemere Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../com/instructure/student/mobius/conferences/conference_details/ConferenceDetailsUpdate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ class ConferenceDetailsUpdate : UpdateInit<ConferenceDetailsModel, ConferenceDet
}
is ConferenceDetailsEvent.RecordingClicked -> {
val recording = model.conference.recordings.first { it.recordingId == event.recordingId }
val url = recording.playbackUrl ?: recording.playbackFormats.firstOrNull()?.url.orEmpty()
val url = recording.playbackUrl
?: recording.playbackFormats.find { it.type == "presentation" }?.url
?: recording.playbackFormats.firstOrNull()?.url.orEmpty()
val newModel = model.copy(
launchingRecordings = model.launchingRecordings.plus(recording.recordingId to true)
)
Expand Down
47 changes: 45 additions & 2 deletions ...om/instructure/student/test/conferences/conference_details/ConferenceDetailsUpdateTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
package com.instructure.student.test.conferences.conference_details

import androidx.test.ext.junit.runners.AndroidJUnit4
import com.instructure.canvasapi2.models.*
import com.instructure.canvasapi2.models.CanvasContext
import com.instructure.canvasapi2.models.Conference
import com.instructure.canvasapi2.models.ConferenceRecording
import com.instructure.canvasapi2.models.Course
import com.instructure.canvasapi2.models.PlaybackFormat
import com.instructure.canvasapi2.utils.ApiPrefs
import com.instructure.canvasapi2.utils.DataResult
import com.instructure.student.mobius.conferences.conference_details.ConferenceDetailsEffect
Expand All @@ -33,7 +37,6 @@ import com.spotify.mobius.test.UpdateSpec
import com.spotify.mobius.test.UpdateSpec.assertThatNext
import io.mockk.every
import io.mockk.mockkObject
import io.mockk.mockkStatic
import io.mockk.unmockkAll
import org.junit.After
import org.junit.Before
Expand Down Expand Up @@ -225,6 +228,46 @@ class ConferenceDetailsUpdateTest {
)
}

@Test
fun `RecordingClicked prioritizes presentation type over notes when playbackUrl is null`() {
val conferenceWithMultipleFormats = baseConference.copy(
recordings = listOf(
ConferenceRecording(
recordingId = "recording_3",
playbackUrl = null,
playbackFormats = listOf(
PlaybackFormat(
length = null,
type = "notes",
url = "https://some.fake.url/recording_3/notes"
),
PlaybackFormat(
length = "1",
type = "presentation",
url = "https://some.fake.url/recording_3/presentation"
)
)
)
)
)
val inputModel = initModel.copy(conference = conferenceWithMultipleFormats)
val expectedModel = inputModel.copy(launchingRecordings = mapOf("recording_3" to true))
updateSpec
.given(inputModel)
.whenEvent(ConferenceDetailsEvent.RecordingClicked(recordingId = "recording_3"))
.then(
assertThatNext(
NextMatchers.hasModel(expectedModel),
matchesEffects(
ConferenceDetailsEffect.ShowRecording(
"recording_3",
"https://some.fake.url/recording_3/presentation"
)
)
)
)
}

@Test
fun `ShowRecordingFinished event updates the model`() {
val recording = baseConference.recordings[0]
Expand Down
2 changes: 1 addition & 1 deletion libs/canvas-api-2/src/main/java/com/instructure/canvasapi2/models/Conference.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ data class ConferenceRecording(

@Parcelize
data class PlaybackFormat(
val length: String,
val length: String?,
val type: String,
val url: String
) : Parcelable
Loading