[MBL-19756][Student] Fix NullPointerException when displaying conference recordings with null length#3503
Merged
kristofnemere merged 2 commits intomasterfrom Feb 5, 2026
Conversation
…nce recordings with null length Make PlaybackFormat.length field nullable to handle API responses where the length field is null (e.g., recordings with type=notes). This prevents crashes when computing hashCode for Conference objects containing such recordings. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
tamaskozmer
approved these changes
Feb 4, 2026
📊 Code Coverage Report
|
🧪 Unit Test Results✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Thu, 05 Feb 2026 10:21:50 GMT |
|
Student Install Page |
adamNagy56
requested changes
Feb 4, 2026
kdeakinstructure
approved these changes
Feb 5, 2026
Contributor
kdeakinstructure
left a comment
kdeakinstructure
left a comment
There was a problem hiding this comment.
QA 👍 (Works on my sandbox, but I've checked Adam's as well at it really does not load there, so that should be investigated).
When displaying conference recordings, prioritize "presentation" type playback formats over "notes" since the API can return them in different orders. Falls back to first format if presentation type is not found. Added test to verify presentation type is selected even when notes appears first in the list. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
kristofnemere
deleted the
MBL-19756-fix-conference-playback-format-null-length
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
Root cause: The API sometimes returns
PlaybackFormatobjects withlength: null(specifically for recordings withtype: "notes"). The Kotlin auto-generatedhashCode()method attempted to call.hashCode()on the nulllengthfield, causing a crash when the Conference object was used in hash-based collections during Mobius state updates.Fix: Changed
PlaybackFormat.lengthfrom non-nullableStringto nullableString?to properly handle API responses.refs: MBL-19756
affects: Student
release note: Fixed crash when viewing conference recordings