[MBL-19679][Teacher][Parent] Add E2E tests for inbox attachment download and opening by adamNagy56 · Pull Request #3504 · instructure/canvas-android

adamNagy56 · 2026-02-04T15:23:17Z

Summary

Add E2E tests for inbox message reply/forward with attachments (video, PDF) in Teacher and Parent apps.

refs: MBL-19679
affects: Teacher, Parent
release note:

Checklist

Run E2E test suite

refs: MBL-19679 affects: Teacher release note:

refs: MBL-19679 affects: Parent release note:

…achment-download-and-opening

claude

Review Summary

This PR adds E2E tests for Inbox message reply and forward functionality with file attachments (video and PDF) for both Parent and Teacher apps. The tests cover important user workflows and the overall structure is well-organized with clear logging.

Positive Aspects

Comprehensive test coverage for reply/forward with attachments
Clear, descriptive logging with PREPARATION_TAG, STEP_TAG, and ASSERTION_TAG
Good use of assertions to verify both message content and attachment display
Tests verify workflows from multiple user perspectives (parent1/parent2, teacher1/teacher2)
Proper test infrastructure additions (FileChooserPage, test utility methods)
Integration with WorkManager test helpers in TestAppManager

Issues Found

Test Reliability - Hard-coded sleep() calls (apps/parent/src/androidTest/java/com/instructure/parentapp/ui/e2e/compose/InboxE2ETest.kt:700, 715, apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/compose/InboxE2ETest.kt:810, 843, 968): Multiple uses of sleep(2000) and sleep(5000) make tests flaky and slow. Replace with IdlingResource, WorkManager test helpers, or polling mechanisms with timeouts.
Incorrect comment (apps/parent/src/androidTest/java/com/instructure/parentapp/ui/e2e/compose/InboxE2ETest.kt:696): Comment says "PDF file" but the code works with a video file.
Legacy storage flag (apps/parent/src/main/AndroidManifest.xml:43): Adding android:requestLegacyExternalStorage="true" is deprecated and has no effect on Android 11+. Consider using scoped storage APIs instead.
Brittle UiAutomator file picker interaction (apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/compose/InboxE2ETest.kt:935-947): Direct UiAutomator interaction with system file picker is fragile across devices/locales. Consider using Espresso intents to stub the file picker (like the parent app does).

Recommendations

Create a shared helper method for waiting on file uploads that uses WorkManager test helpers instead of sleep()
Add timeout and error handling to UiAutomator interactions for better debugging
Document or remove the legacy storage flag if it's not needed
Consider using stubbed file picker intents consistently across both apps for better test reliability

The functionality being tested is valuable, and the test structure is solid. The main improvements needed are around test reliability and avoiding deprecated Android APIs.

apps/parent/src/androidTest/java/com/instructure/parentapp/ui/e2e/compose/InboxE2ETest.kt

claude · 2026-02-04T15:24:26Z

apps/parent/src/main/AndroidManifest.xml

        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:networkSecurityConfig="@xml/network_security_config"
+        android:requestLegacyExternalStorage="true"


Adding android:requestLegacyExternalStorage="true" is a backward compatibility flag for Android 10 that should be avoided for new features. Modern Android apps should use scoped storage (MediaStore API or Storage Access Framework).

Consider:

Is this truly necessary for the feature, or can you use scoped storage APIs?

If this is temporary, add a TODO comment with a plan to migrate to scoped storage

Note that this flag has no effect on Android 11+ (API 30+)

@tamaskozmer please check this if we really need to put this in.

I think this is not a big issue, it does nothing from API level 30+. It can cause some changes on API level 29 or 28, which we still support, but wouldn't cause any issues. I still think that we shouldn't add Manifest properties solely for testing purposes, so if it is possible to overwrite this in the test Manifest (I think this is doable) than please change it to that.

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/compose/InboxE2ETest.kt

github-actions · 2026-02-04T15:40:57Z

📊 Code Coverage Report

✅ Student

PR Coverage: 43.27%
Master Coverage: 43.27%
Delta: +0.00%

✅ Teacher

PR Coverage: 25.47%
Master Coverage: 25.47%
Delta: +0.00%

⚠️ Pandautils

PR Coverage: 23.01%
Master Coverage: 23.01%
Delta: -0.00%

📈 Overall Average

PR Coverage: 30.58%
Master Coverage: 30.58%
Delta: -0.00%

github-actions · 2026-02-04T15:44:06Z

🧪 Unit Test Results

✅ 📱 Parent App

Tests: 309 total, 0 failed, 0 skipped
Duration: 31.202s
Success Rate: 100%

✅ 📱 Teacher App

Tests: 367 total, 0 failed, 0 skipped
Duration: 28.942s
Success Rate: 100%

✅ 📦 Submodules

Tests: 2798 total, 0 failed, 0 skipped
Duration: 46.572s
Success Rate: 100%

📊 Summary

Total Tests: 3474
Failed: 0
Skipped: 0
Status: ✅ All tests passed!

Last updated: Thu, 05 Feb 2026 15:43:26 GMT

github-actions · 2026-02-04T15:44:15Z

Parent Install Page

github-actions · 2026-02-04T15:56:25Z

Teacher Install Page

refs: MBL-19679 affects: Parent release note:

.../src/main/kotlin/com/instructure/canvas/espresso/common/pages/compose/RecipientPickerPage.kt

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/compose/InboxE2ETest.kt

apps/parent/src/androidTest/java/com/instructure/parentapp/ui/e2e/compose/InboxE2ETest.kt

refs: MBL-19679 affects: Teacher, Parent release note:

…achment-download-and-opening

tamaskozmer · 2026-02-05T13:25:22Z

apps/parent/src/main/AndroidManifest.xml

        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:networkSecurityConfig="@xml/network_security_config"
+        android:requestLegacyExternalStorage="true"


I think this is not a big issue, it does nothing from API level 30+. It can cause some changes on API level 29 or 28, which we still support, but wouldn't cause any issues. I still think that we shouldn't add Manifest properties solely for testing purposes, so if it is possible to overwrite this in the test Manifest (I think this is doable) than please change it to that.

refs: MBL-19679 affects: Teacher, Parent release note:

…achment-download-and-opening

adam1014-ai added 3 commits February 4, 2026 12:48

Teacher app inbox attachment related tests.

25c02e4

refs: MBL-19679 affects: Teacher release note:

Parent app inbox attachment related tests.

be1af47

refs: MBL-19679 affects: Parent release note:

Merge branch 'master' into MBL-19679-Implement-E2E-test-for-inbox-att…

65c3ae0

…achment-download-and-opening

claude bot reviewed Feb 4, 2026

View reviewed changes

comment update

de0e4b3

refs: MBL-19679 affects: Parent release note:

kdeakinstructure requested changes Feb 5, 2026

View reviewed changes

adam1014-ai added 2 commits February 5, 2026 11:48

PR fix

9df3b3e

refs: MBL-19679 affects: Teacher, Parent release note:

Merge branch 'master' into MBL-19679-Implement-E2E-test-for-inbox-att…

765b2d9

…achment-download-and-opening

adamNagy56 requested a review from kdeakinstructure February 5, 2026 11:00

kdeakinstructure approved these changes Feb 5, 2026

View reviewed changes

tamaskozmer requested changes Feb 5, 2026

View reviewed changes

adam1014-ai added 2 commits February 5, 2026 16:22

PR fix

d27b11a

refs: MBL-19679 affects: Teacher, Parent release note:

Merge branch 'master' into MBL-19679-Implement-E2E-test-for-inbox-att…

9a5f078

…achment-download-and-opening

Conversation

adamNagy56 commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Review Summary

Positive Aspects

Issues Found

Recommendations

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

kdeakinstructure Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

tamaskozmer Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Code Coverage Report

✅ Student

✅ Teacher

⚠️ Pandautils

📈 Overall Average

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Unit Test Results

✅ 📱 Parent App

✅ 📱 Teacher App

✅ 📦 Submodules

📊 Summary

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tamaskozmer Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adamNagy56 commented Feb 4, 2026 •

edited

Loading

github-actions bot commented Feb 4, 2026 •

edited

Loading

github-actions bot commented Feb 4, 2026 •

edited

Loading

github-actions bot commented Feb 4, 2026 •

edited

Loading

github-actions bot commented Feb 4, 2026 •

edited

Loading