Skip to content

Conversation

@jgardn3r
Copy link
Collaborator

This change always breaks before a multiline string and ensures the
surrounding code is appropriately broken too.

@jgardn3r jgardn3r requested a review from zaneduffield August 21, 2025 06:10
@jgardn3r jgardn3r force-pushed the multiline-string-handling branch from 9eaae87 to 11ef5f0 Compare August 21, 2025 23:04
Copy link
Collaborator

@zaneduffield zaneduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A relatively easy fix for much more consistency with the multi-line strings!

@jgardn3r jgardn3r force-pushed the multiline-string-handling branch from 11ef5f0 to 9c7b1ca Compare August 21, 2025 23:07
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
core/src/rules/optimising_line_formatter/mod.rs 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

This change always breaks before a multiline string and ensures the
surrounding code is appropriately broken.
@jgardn3r jgardn3r force-pushed the multiline-string-handling branch from 9c7b1ca to 2a49ffa Compare August 22, 2025 00:32
@jgardn3r jgardn3r merged commit 62ef6ad into master Aug 22, 2025
7 checks passed
@zaneduffield zaneduffield deleted the multiline-string-handling branch August 22, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants