Add ProtectedSession Related Log in Trace#872
Open
lixin5x wants to merge 1 commit intointel:masterfrom
Open
Conversation
lixin5x
force-pushed
the
trace_cp_2.24
branch
from
12b2602 to
4d97367
Compare
lindongw
reviewed
Feb 6, 2026
va/va_trace.c
Outdated
|
|
||
| /* Print first 16 bytes of IV/CTR */ | ||
| va_TraceMsg(trace_ctx, "\t\t\taes_cbc_iv_or_ctr = "); | ||
| for (unsigned int j = 0; j < 16 && j < 64; j++) { |
Contributor
There was a problem hiding this comment.
duplicate condition: j < 16 && j < 64
more in following code
Contributor
Author
There was a problem hiding this comment.
64 is the buffer size, i think it is meaningful to keep this code here to prevent overflow once someone want to change the dump size 16 by hand, maybe more clear if I use sizeof()
lixin5x
force-pushed
the
trace_cp_2.24
branch
from
4d97367 to
aa0b31b
Compare
Dump structure data of protected session events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dump structure data of protected session events.