[NewOffloadModel] Add support for passing backend options for multiple device architectures#21140
Draft
YixingZhang007 wants to merge 19 commits intointel:syclfrom
Draft
[NewOffloadModel] Add support for passing backend options for multiple device architectures#21140YixingZhang007 wants to merge 19 commits intointel:syclfrom
YixingZhang007 wants to merge 19 commits intointel:syclfrom
Conversation
1ccdc0d to
bee0746
Compare
bee0746 to
e3dffc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the support of passing different backend options through
-Xsycl-target-backendfor each of multiple device architectures.An example is like the following, where we are passing different options for
pvcanddg1.The following changes are made to support this feature:
SYCL.cpp, add a new functionextractDeviceFromArgfor extracting the device from the backend option when the SYCL target isspir64_gen. This allows finding the device architecture from arguments such as:-Xsycl-target-backend=spir64_gen "-device pvc -options -extraopt_pvc"Clang.cpp, we construct a--device-compiler=...argument to pass intoclang-linker-wrapperfor each SYCL target. The--device-compilercontains a-device <arch>to differentiate the device that the backend option is specified for. When the SYCL target isspir64_gen(notintel_gpu_arch), we callextractDeviceFromArgto extract the device architecture.clang-linker-wrapperis updated to filterOPT_device_compiler_args_EQbased on the architecture, and specify each architecture when callingsycl-post-link.sycl-post-linkis updated to support multiple architectures being passed in, such that cases like:-Xsycl-target-backend=spir64_gen "-device arch1,arch2"sycl-offload-new-driver.cppto verify the changes.