Use unknown instead of any for better type safety#75
Open
paulpoot wants to merge 1 commit intointercom:masterfrom
Open
Use unknown instead of any for better type safety#75paulpoot wants to merge 1 commit intointercom:masterfrom
paulpoot wants to merge 1 commit intointercom:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To start this PR off, thank you for this project - I think it's a great tool to improve code quality and developer experience in Contentful/Typescript projects.
Now, I noticed that the generator sometimes returns
anyas a type. While it works, generally it's advised to use theunknowntype in situations like this one, where more detailed typing information is unavailable. It's a minor change, but it does mean that the generated types provide more safety.I'm curious to hear your thoughts about this and hereby provide a PR with the change.