feat(backend): add confirmPartialIncomingPayment resolver#3819
Merged
njlie merged 6 commits intofeature/encrypted-data-exchangefrom Feb 6, 2026
Merged
Conversation
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
Base automatically changed from
nl/raf-1209/update-partial-payment-webhook
to
feature/encrypted-data-exchange
February 4, 2026 16:02
sanducb
approved these changes
Feb 5, 2026
Contributor
sanducb
left a comment
There was a problem hiding this comment.
Looks good, only left one suggestion 👍
| ) | ||
|
|
||
| const redis = await ctx.container.use('redis') | ||
| const cacheKey = `kyc_decision:${input.incomingPaymentId}:${input.partialIncomingPaymentId}` |
Contributor
There was a problem hiding this comment.
I think we could rename this to ase_decision instead of kyc_decision to make it more general. WDYT?
Contributor
Author
There was a problem hiding this comment.
Yeah I think that fits better, actually. I suppose we could make it even more general and call the prefix payment_decision or partial_payment_decision since we don't need to know where the decision came from, just what the decision is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
confirmPartialIncomingPaymentgraphql resolverContext
Fixes RAF-1186.
Checklist
fixes #numberuser-docslabel (if necessary)