Skip to content

feat(backend): add confirmPartialIncomingPayment resolver#3819

Merged
njlie merged 6 commits intofeature/encrypted-data-exchangefrom
nl/raf-1186/confirm-partial-incoming-api
Feb 6, 2026
Merged

feat(backend): add confirmPartialIncomingPayment resolver#3819
njlie merged 6 commits intofeature/encrypted-data-exchangefrom
nl/raf-1186/confirm-partial-incoming-api

Conversation

@njlie
Copy link
Contributor

@njlie njlie commented Feb 3, 2026

Changes proposed in this pull request

  • Adds the confirmPartialIncomingPayment graphql resolver

Context

Fixes RAF-1186.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@njlie njlie requested a review from mkurapov February 3, 2026 01:04
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels Feb 3, 2026
@njlie njlie requested a review from sanducb February 3, 2026 01:04
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 45.22
  • Iterations/s: 15.10
  • Failed Requests: 0.00% (0 of 2725)
📜 Logs

> performance@1.0.0 run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 984 kB 16 kB/s
     data_sent......................: 2.1 MB 35 kB/s
     http_req_blocked...............: avg=6.48µs   min=2.24µs   med=5.05µs   max=611.98µs p(90)=6.04µs   p(95)=6.56µs  
     http_req_connecting............: avg=418ns    min=0s       med=0s       max=562.79µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=87.75ms  min=7.15ms   med=71.98ms  max=592.95ms p(90)=153.09ms p(95)=181.84ms
       { expected_response:true }...: avg=87.75ms  min=7.15ms   med=71.98ms  max=592.95ms p(90)=153.09ms p(95)=181.84ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2725
     http_req_receiving.............: avg=87.27µs  min=27.82µs  med=76.85µs  max=1.53ms   p(90)=114.13µs p(95)=141.92µs
     http_req_sending...............: avg=34.87µs  min=10.17µs  med=27.23µs  max=1.8ms    p(90)=41.1µs   p(95)=53.35µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=87.63ms  min=6.99ms   med=71.88ms  max=592.86ms p(90)=152.97ms p(95)=181.4ms 
     http_reqs......................: 2725   45.217273/s
     iteration_duration.............: avg=264.39ms min=171.44ms med=247.23ms max=1.09s    p(90)=326.59ms p(95)=355.23ms
     iterations.....................: 910    15.10008/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

Base automatically changed from nl/raf-1209/update-partial-payment-webhook to feature/encrypted-data-exchange February 4, 2026 16:02
Copy link
Contributor

@sanducb sanducb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only left one suggestion 👍

)

const redis = await ctx.container.use('redis')
const cacheKey = `kyc_decision:${input.incomingPaymentId}:${input.partialIncomingPaymentId}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could rename this to ase_decision instead of kyc_decision to make it more general. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that fits better, actually. I suppose we could make it even more general and call the prefix payment_decision or partial_payment_decision since we don't need to know where the decision came from, just what the decision is.

@njlie njlie merged commit 0eea5c9 into feature/encrypted-data-exchange Feb 6, 2026
32 of 52 checks passed
@njlie njlie deleted the nl/raf-1186/confirm-partial-incoming-api branch February 6, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants