[messaging] Enhance Expo notification icon configuration support and documentation#8618
[messaging] Enhance Expo notification icon configuration support and documentation#8618
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Co-authored-by: Ehesp <842078+Ehesp@users.noreply.github.com>
Co-authored-by: Ehesp <842078+Ehesp@users.noreply.github.com>
Co-authored-by: Ehesp <842078+Ehesp@users.noreply.github.com>
|
(Playing around, ignore) |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
this is an actual issue though - was just slightly lower priority but I did want to check it out |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8618 +/- ##
===========================================
+ Coverage 52.41% 77.76% +25.35%
===========================================
Files 187 251 +64
Lines 7671 11367 +3696
Branches 1802 2753 +951
===========================================
+ Hits 4020 8838 +4818
+ Misses 3004 2388 -616
+ Partials 647 141 -506 🚀 New features to boost your workflow:
|
|
Hello 👋, this PR has been opened for more than 14 days with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
Summary
This PR addresses issue #8616 by significantly improving the documentation and developer experience for the existing Expo notification icon configuration feature in @react-native-firebase/messaging.
The messaging package already includes an Expo config plugin (added in v18.7.0 via #7369) that automatically configures Firebase notification icons and colors from
app.json, but this functionality was poorly documented and largely unknown to users.Changes Made
📚 Enhanced Documentation
docs/messaging/usage/index.mdwith comprehensive Expo configuration section including:app.jsonconfigurationpackages/messaging/README.mdwith clear Expo setup instructions and examplepackages/messaging/EXPO_EXAMPLE.mdwith detailed examples and best practices🔧 Improved Developer Experience
[@react-native-firebase/messaging]✅ Enhanced Testing
How It Works
The existing Expo plugin automatically:
expo.notification.iconandexpo.notification.colorfromapp.jsoncom.google.firebase.messaging.default_notification_iconcom.google.firebase.messaging.default_notification_colorExample Configuration
{ "expo": { "notification": { "icon": "./assets/notification-icon.png", "color": "#FF0000" }, "plugins": [ "@react-native-firebase/messaging" ] } }Before vs After
Before: Users were unaware this feature existed and requested it as a new feature
After: Clear documentation and improved messaging make the feature discoverable and easy to use
Testing
This PR transforms an existing but hidden feature into a well-documented, user-friendly solution that fully addresses the feature request in #8616.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
docs.expo.devcurl -s REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.