feat(expo): enhances notification config retrieval#8663
feat(expo): enhances notification config retrieval#8663huextrat wants to merge 3 commits intoinvertase:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Ping @mikehardy - @MichaelVerdon to get your opinion on this |
|
just closing and reopening to make sure CI runs, it appears to be hung for some reason |
Improves notification configuration by first checking `expo-notifications` plugin for icon and color. Falls back to deprecated `config.notification` settings. Warns about missing notification icon for Android.
ac96a96 to
baf4c89
Compare
I did a rebase on latest main + fix lint |
|
duplicate test b263759 to make sure both configuration are working |
|
Any ETA for next version with this change? |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Ping @mikehardy @MichaelVerdon, this is not stale |
|
apologies for the delay - been spinning through all the Invertase npmjs packages implementing their new Trusted Publish thing so we can keep releasing software at all, and it's delayed me going through PRs here. This is on the radar though |
38a52cd to
7af280b
Compare
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Ping. Still an issue (sorry, the bot requires it, I understand it might take longer) |
|
@mikehardy SDK 55 beta is now available and Any idea how long it will take before we can merge this? |
|
Not much longer, I do finally have a full expo build demo which allows me to reproduce / confirm Expo stuff more generally (with arbitrary versions including pre-release) https://github.com/mikehardy/rnfbdemo/blob/main/make-expo-demo.sh - but sadly it's because of this hot topic here I must get that completely solved first - appears it may be close, so, on the order of days I believe Thanks for your patience |
Description
Expo 54 will deprecate the use of
notificationin expo config in favor ofexpo-notificationsexpo plugin : https://docs.expo.dev/versions/v54.0.0/config/app/#notificationImproves notification configuration by first checking
expo-notificationsplugin for icon and color.Falls back to deprecated
config.notificationsettings. Warns about missing notification icon for Android.Related issues
fixes: #8664
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter