fix: Fabric codegen support for new arch#792
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~792 Documentation is deployed and generated using docs.page. |
|
|
|
Awesome, great work! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 43.72% 36.34% -7.37%
==========================================
Files 30 37 +7
Lines 549 677 +128
Branches 151 180 +29
==========================================
+ Hits 240 246 +6
- Misses 309 431 +122 🚀 New features to boost your workflow:
|
|
@globemediaofficial why did you add the NativeViewManager interface by the way? It's already defined in the header file. |
|
@dylancom Not sure how that got added... probably an accidental paste. You’re right, it’s a duplicate, so it can be removed. Sorry about that! |
|
🎉 This PR is included in version 15.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
The native ad components were incorrectly implemented for React Native 0.81 with the new architecture enabled. Legacy components were being used, which caused a crash in recent versions. This PR fixes that crash by correcting the codegen and editing the native code so that
ViewManager(legacy) implementations are only used for the old architecture.Related issues
Fixes #777
Release Summary
Checklist
iOSTest Plan