fix crash in some rare eventlet edge cases#71
Open
anarcat wants to merge 1 commit intoionelmc:masterfrom
Open
Conversation
Owner
|
I am not really a fan of this approach of ignoring attribute errors and I think in the future it will create more problem than it solves. Now looking at the traceback I wonder if this problem is not simply caused by manhole trying to import eventlet too eagerly. Would having a check in sys.modules for eventlet (eg: only try to import it if it was already imported) solve your problem? Shouldn't need to import eventlet/gevent if they didn't patch anything anyway (eg: them not being in sys.modules means we get the original stuff). Can you try this approach? |
Author
|
Now looking at the traceback I wonder if this problem is not simply caused by manhole trying to import eventlet too eagerly. Would having a check in sys.modules for eventlet (eg: only try to import it if it was already imported) solve your problem? Shouldn't need to import eventlet/gevent if they didn't patch anything anyway (eg: them not being in sys.modules means we get the original stuff). Can you try this approach?
Makes sense, will give that a shot.
|
Author
|
i tried that, let me know if it's what you think. i don't have any gevent or eventlet code here to test this path, but the "normal" path works with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #70