Skip to content

Fix xUnit test name parsing with floating point parameters #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −1
Draft

Fix xUnit test name parsing with floating point parameters #2127

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bb8a0d
Initial plan
Copilot Feb 11, 2026
c187554
Fix xUnit test name parsing for floating point parameters
Copilot Feb 11, 2026
176618e
Update comment to clarify fallback behavior
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Components/TestExplorer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,17 @@ module TestItemDTO =
// NOTE: XUnit includes the FullyQualifiedName in the DisplayName.
// But it doesn't nest theory cases, just appends the case parameters
if dto.DisplayName <> dto.FullName then
let theoryCaseFragment = dto.DisplayName.Split('.') |> Array.last
// The DisplayName includes the FullName as a prefix, so we extract the parameter portion
// Example: FullName="MyModule.MyTest", DisplayName="MyModule.MyTest(x: 0.5, y: 0.25)"
// We need to extract "(x: 0.5, y: 0.25)" not just "25)" as would happen with Split('.')
let theoryCaseFragment =
if dto.DisplayName.StartsWith(dto.FullName) then
dto.DisplayName.Substring(dto.FullName.Length)
else
// Fallback: if DisplayName doesn't start with FullName (unexpected case),
// use the old behavior. This may still have issues with floating point parameters.
dto.DisplayName.Split('.') |> Array.last

dto.FullName + "." + theoryCaseFragment
else
dto.FullName
Expand Down