refactor: write server entities in separate function#463
Open
cristiGuranIonos wants to merge 2 commits intomasterfrom
Open
refactor: write server entities in separate function#463cristiGuranIonos wants to merge 2 commits intomasterfrom
cristiGuranIonos wants to merge 2 commits intomasterfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
cbeti-ionos
reviewed
Nov 8, 2023
| } | ||
|
|
||
| // get additional data for schema | ||
| foundServer, apiResponse, err := client.ServersApi.DatacentersServersFindById(ctx, datacenterId, *postServer.Id).Depth(4).Execute() |
Member
There was a problem hiding this comment.
setting entities data previously used this foundServer value, is it equivalent to postServer at line 632 which is now used instead?
| } | ||
| } | ||
| // what we get from backend | ||
| foundFirstNic := (*server.Entities.Nics.Items)[0] |
Member
There was a problem hiding this comment.
outside nil-check for Entities.Nics, also seems to be duplicated at line 675
|
|
||
| if sentFirstNic.Entities != nil && sentFirstNic.Entities.Firewallrules != nil && sentFirstNic.Entities.Firewallrules.Items != nil { | ||
| sentRules := *sentFirstNic.Entities.Firewallrules.Items | ||
| foundFirstNic := (*server.Entities.Nics.Items)[0] |
Member
There was a problem hiding this comment.
if this needs to be used at line 714, it will go out of scope before that point
Collaborator
Author
|
/test datacenter |
6 similar comments
Collaborator
Author
|
/test datacenter |
Collaborator
Author
|
/test datacenter |
Collaborator
Author
|
/test datacenter |
Collaborator
Author
|
/test datacenter |
Collaborator
Author
|
/test datacenter |
Collaborator
Author
|
/test datacenter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Checklist
feat:/fix:/doc:/test:/refactor:)