This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Revert LS taking too long#1867
Open
GalRogozinski wants to merge 1 commit intoiotaledger-archive:release-v1.8.6from
Open
Revert LS taking too long#1867GalRogozinski wants to merge 1 commit intoiotaledger-archive:release-v1.8.6from
GalRogozinski wants to merge 1 commit intoiotaledger-archive:release-v1.8.6from
Conversation
This reverts commit d6cdd03.
DyrellC
approved these changes
May 26, 2020
Contributor
DyrellC
left a comment
DyrellC
left a comment
There was a problem hiding this comment.
Although I'm not 100% sure that this caused the issue we saw it is the only thing that touched LocalSnapshots so it seems the most likely candidate, and it doesn't necessarily hurt us much to revert it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Reverts #1843 due to problems we found in testing.
Type of change
Choose a type of change, and delete any options that are not relevant.