feat(routing/dht/zikade): add dht routing implementation using zikade#472
Open
feat(routing/dht/zikade): add dht routing implementation using zikade#472
Conversation
Jorropo
reviewed
Sep 26, 2023
Contributor
Jorropo
left a comment
Jorropo
left a comment
There was a problem hiding this comment.
routing/dht does not exists btw, no need to add v2
Contributor
Author
Understood. I chose this on the assumption that dht v1 would still be needed for a while and might end up in Boxo. Happy to remove the v2 if needed |
iand
changed the title
Contributor
|
@iand : just in case this was an accident, the team teans to not look at draft PRs. Please callout if you're wanting feedback on the current state (or move out of draft). |
Contributor
Author
|
@BigLep it's not an accident, I wanted early visibility while I am working on it. Will mark it ready for review when complete. |
iand
changed the title
Codecov Report
@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 65.57% 65.51% -0.06%
==========================================
Files 207 207
Lines 25543 25543
==========================================
- Hits 16749 16735 -14
- Misses 7323 7335 +12
- Partials 1471 1473 +2 |
Contributor
Author
|
@Jorropo would you be able to take another look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the Zikade Amino DHT implementation as a routing choice.