blockservice: stop using deprecated NewWriteThrough in tests#560
Merged
Jorropo merged 2 commits intoblockservice-optfrom Jan 15, 2024
Merged
Conversation
This was referenced Jan 15, 2024
Merged
Contributor
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Jan 15, 2024
This was referenced Jan 15, 2024
Jorropo
force-pushed
the
blockservice-stop-using-NewWriteThrough-in-tests
branch
from
afd5403 to
b8ac21b
Compare
This was referenced Jan 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## blockservice-docs #560 +/- ##
=====================================================
- Coverage 65.41% 65.16% -0.25%
=====================================================
Files 204 204
Lines 25552 25597 +45
=====================================================
- Hits 16715 16681 -34
- Misses 7357 7433 +76
- Partials 1480 1483 +3 |
hacdias
approved these changes
Jan 15, 2024
Member
hacdias
left a comment
hacdias
left a comment
There was a problem hiding this comment.
Considering it has been deprecated in a previous major release, I think it's fine to finally remove it.
This was referenced Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.